chore: sync macros and dashboard fixes to the current PR end state - #8
Merged
Conversation
develop already carried the original squashed macros fix (30cd662) and an earlier draft of the dashboard drag and drop feature (e617487). Brings both up to the state of the currently open upstream PRs after review: - SettingsMacrosTabExpert.vue: macroListLoaded now treats a genuinely empty, fully loaded macro list as loaded instead of requiring allMacros.length > 0, so real deletions are reported once Klipper is ready rather than only once at least one macro exists. - Dashboard.vue / store/gui/getters.ts: scoped styles use ::v-deep for the three selectors that reach into Panel.vue instead of a global style block, the drag group is a constant instead of a per viewport getter (only one viewport ever renders), and the comment on getStoredPanels is gone, per meteyou's review on mainsail-crew#2611. All other files already matched between develop and the current PR branches. Signed-off-by: Åsmund Collin <aakjaergaard@gmail.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brings
developup to date with the reviewed/final state of the three macros PRs (mainsail-crew#2617, mainsail-crew#2618, mainsail-crew#2619) and the dashboard PR (mainsail-crew#2611), replacing the earlier squashed macros fix (30cd662) and draft dashboard feature (e617487) already on this branch.Changed vs. what's currently on
develop:SettingsMacrosTabExpert.vue:macroListLoadednow treats a fully-loaded, genuinely empty macro list as loaded instead of requiringallMacros.length > 0.Dashboard.vue/store/gui/getters.ts: scoped styles via::v-deepinstead of a global style block, constant drag group instead of a per-viewport getter, comment removed ongetStoredPanels— per meteyou's review on feat(dashboard): rearrange panels via drag and drop mainsail-crew/mainsail#2611.All other files touched by the four PRs already matched byte-for-byte what's on
develop, so they aren't part of this diff.Verified:
vitest run(60/60),eslint src --max-warnings 0,vite build.